Re: Linux 4.12-rc6

From	Andy Whitcroft <apw@canonical.com>
Newsgroups	linux.kernel
Subject	Re: Linux 4.12-rc6
Date	2017-06-20 11:20 +0200
Message-ID	<tUnui-6Hb-33@gated-at.bofh.it> (permalink)
References	<tU6tr-4hT-3@gated-at.bofh.it> <tUfdo-1mH-5@gated-at.bofh.it> <tUhfc-2Gn-11@gated-at.bofh.it> <tUhRU-37F-11@gated-at.bofh.it> <tUikW-3gU-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 20, 2017 at 4:42 AM, Dave Jones <davej@codemonkey.org.uk> wrote:

> Almost shutdown, but not quite.  Coincidentally, coverity just finished
> the rc6 run, and barfed this up..  related ?
>
> *** CID 1412907:  Control flow issues  (DEADCODE)
> /include/linux/mm.h: 2243 in vm_end_gap()
> 2237
> 2238     static inline unsigned long vm_end_gap(struct vm_area_struct *vma)
> 2239     {
> 2240            unsigned long vm_end = vma->vm_end;
> 2241
> 2242            if (vma->vm_flags & VM_GROWSUP) {
>>>>     CID 1412907:  Control flow issues  (DEADCODE)
>>>>     Execution cannot reach this statement: "vm_end += stack_guard_gap;".
> 2243                    vm_end += stack_guard_gap;
> 2244                    if (vm_end < vma->vm_end)
> 2245                            vm_end = -PAGE_SIZE;
> 2246            }
> 2247            return vm_end;
> 2248     }

I suspect this is because coverity can tell we do not use VM_GROWSUP
in x86.  I assume it would say the corresponding thing about the
VM_GROWSDOWN code in vm_start_gap() on those architectures with upward
growing stacks.

-apw

Thread

Linux 4.12-rc6 Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-19 17:10 +0200
  Re: Linux 4.12-rc6 Dave Jones <davej@codemonkey.org.uk> - 2017-06-20 02:30 +0200
    Re: Linux 4.12-rc6 Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-20 04:40 +0200
      Re: Linux 4.12-rc6 Dave Jones <davej@codemonkey.org.uk> - 2017-06-20 05:00 +0200
      Re: Linux 4.12-rc6 Hugh Dickins <hughd@google.com> - 2017-06-20 05:20 +0200
        Re: Linux 4.12-rc6 Dave Jones <davej@codemonkey.org.uk> - 2017-06-20 05:50 +0200
          Re: Linux 4.12-rc6 Hugh Dickins <hughd@google.com> - 2017-06-20 11:10 +0200
            Re: Linux 4.12-rc6 Dave Jones <davej@codemonkey.org.uk> - 2017-06-20 16:50 +0200
          Re: Linux 4.12-rc6 Andy Whitcroft <apw@canonical.com> - 2017-06-20 11:20 +0200
        Re: Linux 4.12-rc6 Hugh Dickins <hughd@google.com> - 2017-06-20 06:50 +0200

csiph-web