Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1670332

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'
Date 2017-06-20 08:40 +0200
Message-ID <tUkZr-51E-3@gated-at.bofh.it> (permalink)
References <tUkPM-4Yr-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:

> If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error
> handling path to free it in such a case.
>
> Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

The prefix should be "brcmfmac:", like in the commit you are fixing.
"cfg80211:" is very misleading.

-- 
Kalle Valo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-20 08:30 +0200
  Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach' Kalle Valo <kvalo@codeaurora.org> - 2017-06-20 08:40 +0200
  Re: [PATCH] cfg80211: Fix a memory leak in error handling path in  'brcmf_cfg80211_attach' Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-06-20 22:00 +0200

csiph-web