Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670207

Re: [PATCH v2 2/9] kvm-vfio: Decouple only when we match a group

Show all headers | View raw

On 20/06/17 03:14, Alex Williamson wrote:
> Unset-KVM and decrement-assignment only when we find the group in our
> list.  Otherwise we can get out of sync if the user triggers this for
> groups that aren't currently on our list.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> Cc: stable@vger.kernel.org
> ---
>  virt/kvm/vfio.c |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c
> index 37d9118fd84b..f1b0b7bca9a9 100644
> --- a/virt/kvm/vfio.c
> +++ b/virt/kvm/vfio.c
> @@ -246,21 +246,19 @@ static int kvm_vfio_set_group(struct kvm_device *dev, long attr, u64 arg)
>  				continue;
>  
>  			list_del(&kvg->node);
> +			kvm_arch_end_assignment(dev->kvm);
> +#ifdef CONFIG_SPAPR_TCE_IOMMU
> +			kvm_spapr_tce_release_vfio_group(dev->kvm, vfio_group);
> +#endif
> +			kvm_vfio_group_set_kvm(kvg->vfio_group, NULL);
>  			kvm_vfio_group_put_external_user(kvg->vfio_group);
>  			kfree(kvg);
>  			ret = 0;
>  			break;
>  		}
>  
> -		kvm_arch_end_assignment(dev->kvm);
> -
>  		mutex_unlock(&kv->lock);
>  
> -#ifdef CONFIG_SPAPR_TCE_IOMMU
> -		kvm_spapr_tce_release_vfio_group(dev->kvm, vfio_group);
> -#endif
> -		kvm_vfio_group_set_kvm(vfio_group, NULL);


Tiny nit: vfio_group becomes kvg->vfio_group in kvm_vfio_group_set_kvm()
and does not in kvm_spapr_tce_release_vfio_group().


Anyway,

Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>



> -
>  		kvm_vfio_group_put_external_user(vfio_group);
>  
>  		kvm_vfio_update_coherency(dev);
> 


-- 
Alexey

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] vfio: Fix release ordering races and use  driver_override Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 7/9] vfio: Use driver_override to avert binding to  compromising drivers Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 4/9] iommu: Add driver-not-bound notification Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 1/9] vfio: Fix group release deadlock Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 9/9] vfio: Add AMBA driver_override support Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 3/9] vfio: New external user group/file match Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
    Re: [PATCH v2 3/9] vfio: New external user group/file match kbuild test robot <lkp@intel.com> - 2017-06-20 07:10 +0200
  [PATCH v2 6/9] vfio: Register pci, platform, amba,  and mdev bus drivers Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
  [PATCH v2 8/9] amba: Export amba_bustype Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
    Re: [PATCH v2 8/9] amba: Export amba_bustype Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-19 19:40 +0200
      Re: [PATCH v2 8/9] amba: Export amba_bustype Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 20:00 +0200
  [PATCH v2 2/9] kvm-vfio: Decouple only when we match a group Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200
    Re: [PATCH v2 2/9] kvm-vfio: Decouple only when we match a group Alexey Kardashevskiy <aik@ozlabs.ru> - 2017-06-20 04:40 +0200
      Re: [PATCH v2 2/9] kvm-vfio: Decouple only when we match a group Alex Williamson <alex.williamson@redhat.com> - 2017-06-20 04:50 +0200
  [PATCH v2 5/9] vfio: Create interface for vfio bus drivers to  register Alex Williamson <alex.williamson@redhat.com> - 2017-06-19 19:20 +0200

csiph-web