[patch 25/55] genirq/cpuhotplug: Remove irq disabling logic

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	[patch 25/55] genirq/cpuhotplug: Remove irq disabling logic
Date	Tue, 20 Jun 2017 02:10:04 +0200
Message-ID	<tUeU4-1fU-87@gated-at.bofh.it> (permalink)
References	<tUeKl-Xe-5@gated-at.bofh.it>
User-Agent	quilt/0.63-1
MIME-Version	1.0
Content-Type	text/plain; charset=ISO-8859-15
Content-Disposition	inline; filename=genirq-cpuhotplug--Remove-irq-disabling-logic.patch
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Marc Zyngier <marc.zyngier@arm.com>, Christoph Hellwig <hch@lst.de>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Michael Ellerman <mpe@ellerman.id.au>, Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>
X-Original-Date	Tue, 20 Jun 2017 01:37:25 +0200
X-Original-Message-ID	<20170619235445.198042748@linutronix.de>
X-Original-References	<20170619233700.547167146@linutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1670098

Show key headers only | View raw

This is called from stop_machine() with interrupts disabled. No point in
disabling them some more.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/cpuhotplug.c |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

--- a/kernel/irq/cpuhotplug.c
+++ b/kernel/irq/cpuhotplug.c
@@ -59,11 +59,8 @@ static bool migrate_one_irq(struct irq_d
  */
 void irq_migrate_all_off_this_cpu(void)
 {
-	unsigned int irq;
 	struct irq_desc *desc;
-	unsigned long flags;
-
-	local_irq_save(flags);
+	unsigned int irq;
 
 	for_each_active_irq(irq) {
 		bool affinity_broken;
@@ -73,10 +70,9 @@ void irq_migrate_all_off_this_cpu(void)
 		affinity_broken = migrate_one_irq(desc);
 		raw_spin_unlock(&desc->lock);
 
-		if (affinity_broken)
-			pr_warn_ratelimited("IRQ%u no longer affine to CPU%u\n",
+		if (affinity_broken) {
+			pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
 					    irq, smp_processor_id());
+		}
 	}
-
-	local_irq_restore(flags);
 }

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch 25/55] genirq/cpuhotplug: Remove irq disabling logic Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 02:10 +0200
  [tip:irq/core] genirq/cpuhotplug: Remove irq disabling logic tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-06-22 19:00 +0200

csiph-web