Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1669918

[PATCH 5/7] powerpc: Don't fortify prom_init

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject [PATCH 5/7] powerpc: Don't fortify prom_init
Date 2017-06-19 22:30 +0200
Message-ID <tUbt8-7sP-29@gated-at.bofh.it> (permalink)
References <tUbt8-7sP-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Daniel Axtens <dja@axtens.net>

prom_init is a bit special; in theory it should be able to be
linked separately to the kernel. To keep this from getting too
complex, the symbols that prom_init.c uses are checked.

Fortification adds symbols, and it gets quite messy as it includes
things like panic(). So just don't fortify prom_init.c for now.

Cc: Kees Cook <keescook@chromium.org>
Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/powerpc/kernel/prom_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index dd8a04f3053a..613f79f03877 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -15,6 +15,9 @@
 
 #undef DEBUG_PROM
 
+/* we cannot use FORTIFY as it brings in new symbols */
+#define __NO_FORTIFY
+
 #include <stdarg.h>
 #include <linux/kernel.h>
 #include <linux/string.h>
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] CONFIG_FORTIFY_SOURCE Kees Cook <keescook@chromium.org> - 2017-06-19 22:30 +0200
  [PATCH 3/7] kexec_file: Adjust declaration of kexec_purgatory Kees Cook <keescook@chromium.org> - 2017-06-19 22:30 +0200
  [PATCH 5/7] powerpc: Don't fortify prom_init Kees Cook <keescook@chromium.org> - 2017-06-19 22:30 +0200
  [PATCH 1/7] efi: Avoid fortify checks in EFI stub Kees Cook <keescook@chromium.org> - 2017-06-19 22:30 +0200
  Re: [PATCH 0/7] CONFIG_FORTIFY_SOURCE Andrew Morton <akpm@linux-foundation.org> - 2017-06-20 00:00 +0200
    Re: [PATCH 0/7] CONFIG_FORTIFY_SOURCE Kees Cook <keescook@chromium.org> - 2017-06-20 00:20 +0200
      Re: [PATCH 0/7] CONFIG_FORTIFY_SOURCE Andrew Morton <akpm@linux-foundation.org> - 2017-06-20 00:40 +0200

csiph-web