Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls

From	Deepa Dinamani <deepa.kernel@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls
Date	2017-06-19 23:00 +0200
Message-ID	<tUbWb-7E3-27@gated-at.bofh.it> (permalink)
References	<tTYFA-7yd-9@gated-at.bofh.it> <tTZih-83v-11@gated-at.bofh.it> <tUaGK-6Vi-19@gated-at.bofh.it> <tUaQq-6YO-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 19, 2017 at 12:46 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, Jun 19, 2017 at 12:31:00PM -0700, Deepa Dinamani wrote:
>
>> 3. I was also aiming for user pointers to be not touched by timer
>> specific code as it can get messy if not handled properly with 2
>> compat time_t versions.
>
> So have one helper that deals with all copyout and have it used by
> all of them.  IMO all that code should treat userland representation
> as completely opaque.  Just switch nanosleep_copyout() to take
> timespec64 instead of timespec (for kernel-side object) and that'll
> do it, wouldn't it?

Yes, that would work.
If that is preferred, then I will just do that and rebase the patches.

>> Do you guys see any benefit in doing it the way patch 4/8 in the
>> current series does?
>
> Well, if you want to keep more restart functions and more boilerplate
> on compat side...

Yes, there is no good way of achieving everything because of backward
compatibility.

Thanks,
Deepa

Thread

[PATCH 0/8] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 4/8] nanosleep: Use get_timespec64() and set_timespec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 7/8] posix_clocks: Use get_itimerspec64() and put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 8/8] timerfd: Use get_itimerspec64() and put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 1/8] time: add get_timespec64 and put_timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 6/8] time: introduce {get,put}_itimerspec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  [PATCH 5/8] posix-timers: Use get_timepsec64() and put_timespec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 08:50 +0200
  Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-19 09:30 +0200
    Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 21:40 +0200
      Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-19 21:50 +0200
        Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-19 23:00 +0200
          Re: [PATCH 0/8] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-19 23:20 +0200

csiph-web