Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669932

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb
Date 2017-06-19 22:50 +0200
Message-ID <tUbMt-7Ag-3@gated-at.bofh.it> (permalink)
References <tUbCO-7vX-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:


> +#ifdef CONFIG_X86
> +       primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> +                                       IORESOURCE_ROM_SHADOW;
> +#endif

Why do we need #ifdef?

In any case you may introduce a temporary variable to have pointer to resource

struct resource *res = &pdev->resource[PCI_ROM_RESOURCE];

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-19 22:40 +0200
  Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-19 22:50 +0200
    Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-20 22:10 +0200
      Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-20 22:30 +0200
        Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-20 22:50 +0200
        Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-20 22:50 +0200
        Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-20 22:50 +0200
  Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-25 14:50 +0200
    Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-25 15:00 +0200
      Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-25 16:00 +0200
        Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-25 16:30 +0200
          Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-25 17:10 +0200
            Re: 答复: [PATCH 1/2] staging:  sm750fb: avoid conflicting vesafb Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200

csiph-web