[PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable warning

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable warning
Date	2017-06-22 00:00 +0200
Message-ID	<tUVPj-3BI-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The last rework returned a variable that the compiler cannot prove
to be initialized:

arch/arm/mach-iop13xx/pci.c: In function 'iop13xx_scan_bus':
arch/arm/mach-iop13xx/pci.c:509:17: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

In the switch statement that sets the return value, this adds
a default returning an error.

Fixes: ace27646da8e ("ARM/PCI: Convert PCI scan API to pci_scan_root_bus_bridge()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-iop13xx/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-iop13xx/pci.c b/arch/arm/mach-iop13xx/pci.c
index b97879bfb81a..3c51a9bb9b49 100644
--- a/arch/arm/mach-iop13xx/pci.c
+++ b/arch/arm/mach-iop13xx/pci.c
@@ -553,6 +553,8 @@ int iop13xx_scan_bus(int nr, struct pci_host_bridge *bridge)
 		if (!ret)
 			pci_bus_atue = bridge->bus;
 		break;
+	default:
+		ret = -EINVAL;
 	}
 
 	return ret;
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable warning Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:00 +0200
  Re: [PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable  warning Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-06-22 10:50 +0200
  Re: [PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable  warning Bjorn Helgaas <helgaas@kernel.org> - 2017-06-28 00:40 +0200

csiph-web