Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671965

Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

Show all headers | View raw

On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote:
> This function compiles to 147 bytes of machine code. 13 callsites.
> 
> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
> SCTP events are not happening on every packet.
> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
> Does not look performance critical.

Thanks.

But:

> diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c
[]
> @@ -88,7 +88,7 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event)
>  /* Hold the association in case the msg_name needs read out of
>   * the association.
>   */
> -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
> +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
>  					   const struct sctp_association *asoc)
>  {
>  	struct sctp_chunk *chunk = event->chunk;

This now misaligns the next line after the inline removal.

Can you please run your patches through checkpatch?

$ ./scripts/checkpatch.pl -
CHECK: Alignment should match open parenthesis
#86: FILE: net/sctp/ulpevent.c:92:
+static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
 					   const struct sctp_association *asoc)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2017-06-21 18:30 +0200
  Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner,  save 1616 bytes Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2017-06-21 19:00 +0200
  Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner,  save 1616 bytes Joe Perches <joe@perches.com> - 2017-06-21 21:20 +0200
    Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner,  save 1616 bytes David Miller <davem@davemloft.net> - 2017-06-21 21:30 +0200

csiph-web