Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500
Date	2017-06-21 20:10 +0200
Message-ID	<tUSeJ-1fP-5@gated-at.bofh.it> (permalink)
References	<tPb0J-1BU-7@gated-at.bofh.it> <tPb0J-1BU-5@gated-at.bofh.it> <tUJ1M-3E2-27@gated-at.bofh.it> <tUL3A-4SB-17@gated-at.bofh.it> <tUQZj-aB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 21, 2017 at 6:48 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 21.06.2017 um 12:25 schrieb Arnd Bergmann:
>> On Wed, Jun 21, 2017 at 10:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Tue, Jun 6, 2017 at 2:54 AM, Andreas Färber <afaerber@suse.de> wrote:
>>>> Allow to bring up CPU1.
>>>>
>>>> Based on LeMaker linux-actions tree.
>>>>
>>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>>> ---
>>>>  v3 -> v4: Unchanged
>>>>
>>>>  v3: new
>>>>
>>>>  arch/arm/mach-actions/Makefile  |   3 +
>>>>  arch/arm/mach-actions/headsmp.S |  68 ++++++++++++++++
>>>>  arch/arm/mach-actions/platsmp.c | 166 ++++++++++++++++++++++++++++++++++++++++
>>>
>>> I now see build errors in linux-next:
>>>
>>> /git/arm-soc/arch/arm/mach-actions/platsmp.c: In function 'write_pen_release':
>>> /git/arm-soc/arch/arm/mach-actions/platsmp.c:39:2: error:
>>> 'pen_release' undeclared (first use in this function); did you mean
>>
>> I have a fix and tested it now. Please fold this into your patch:
>>
>>        Arnd
>>
>> Subject: [PATCH] ARM: owl: fix non-SMP build
>>
>> arch/arm/mach-actions/platsmp.c: In function 'write_pen_release':
>> arch/arm/mach-actions/platsmp.c:39:2: error: 'pen_release' undeclared
>> (first use in this function); did you mean 'seq_release'?
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> diff --git a/arch/arm/mach-actions/Makefile b/arch/arm/mach-actions/Makefile
>> index 217e95d04b43..94f8dbafba21 100644
>> --- a/arch/arm/mach-actions/Makefile
>> +++ b/arch/arm/mach-actions/Makefile
>> @@ -1,4 +1,4 @@
>> -obj-$(CONFIG_ARCH_ACTIONS) += owl.o
>> -obj-${CONFIG_ARCH_ACTIONS} += platsmp.o headsmp.o
>> +obj-y += owl.o
>> +obj-$(CONFIG_SMP) += platsmp.o headsmp.o
>
> Sorry. Fixed up the two patches, thanks!
>
> Interestingly the below issue had been found by automatic patch testing,
> but the above wasn't. Maybe you can contribute your non-SMP config for
> the bots, to help catch this earlier?

This was just a randconfig build. On ARM32, we do test
"multi_v7_defconfig+CONFIG_SMP=n"
in kernelci, but that only tests mach-actions after that gets added to
multi_v7_defconfig. Not sure if it's worth adding an allmodconfig+CONFIG_SMP=n"
build, the allmodconfig builds are rather expensive.

        Arnd

Thread

Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Arnd Bergmann <arnd@arndb.de> - 2017-06-21 10:20 +0200
  Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Arnd Bergmann <arnd@arndb.de> - 2017-06-21 12:30 +0200
    Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Andreas Färber <afaerber@suse.de> - 2017-06-21 18:50 +0200
      Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Arnd Bergmann <arnd@arndb.de> - 2017-06-21 20:10 +0200
  Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Arnd Bergmann <arnd@arndb.de> - 2017-06-29 17:10 +0200
    Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Andreas Färber <afaerber@suse.de> - 2017-06-29 17:30 +0200
      Re: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Arnd Bergmann <arnd@arndb.de> - 2017-06-29 18:00 +0200
        [PATCH] ARM: owl: smp: Drop bogus holding pen Andreas Färber <afaerber@suse.de> - 2017-07-01 23:40 +0200
          Re: [PATCH] ARM: owl: smp: Drop bogus holding pen Arnd Bergmann <arnd@arndb.de> - 2017-07-03 14:40 +0200
      答复: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 刘炜 <liuwei@actions-semi.com> - 2017-07-01 07:00 +0200
        Re: 答复: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 Andreas Färber <afaerber@suse.de> - 2017-07-01 22:00 +0200
          RE: RE: [PATCH v4 20/28] ARM: owl: Implement CPU enable-method for S500 刘炜 <liuwei@actions-semi.com> - 2017-07-03 10:20 +0200

csiph-web