[PATCH] minix: Deinline get_block, save 2691 bytes

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Denys Vlasenko <dvlasenk@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] minix: Deinline get_block, save 2691 bytes
Date	Wed, 21 Jun 2017 19:50:01 +0200
Message-ID	<tURVn-Rb-13@gated-at.bofh.it> (permalink)
X-Original-To	Al Viro <viro@zeniv.linux.org.uk>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 8612C859FA
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dvlasenk@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 8612C859FA
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.15
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 21 Jun 2017 17:46:52 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Denys Vlasenko <dvlasenk@redhat.com>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 21 Jun 2017 19:46:47 +0200
X-Original-Message-ID	<20170621174647.5540-1-dvlasenk@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1671850

Show key headers only | View raw

This function compiles to 1402 bytes of machine code.

It has 2 callsites, and also a not-inlined copy gets created by compiler
anyway since its address gets passed as a parameter to block_truncate_page().

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Al Viro <viro@zeniv.linux.org.uk>
CC: linux-fsdevel@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 fs/minix/itree_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/minix/itree_common.c b/fs/minix/itree_common.c
index 4c57c9a..2325777 100644
--- a/fs/minix/itree_common.c
+++ b/fs/minix/itree_common.c
@@ -142,7 +142,7 @@ static inline int splice_branch(struct inode *inode,
 	return -EAGAIN;
 }
 
-static inline int get_block(struct inode * inode, sector_t block,
+static int get_block(struct inode * inode, sector_t block,
 			struct buffer_head *bh, int create)
 {
 	int err = -EIO;
-- 
1.8.3.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] minix: Deinline get_block, save 2691 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2017-06-21 19:50 +0200

csiph-web