Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1671789

Re: [net-next PATCH] tcp: md5: hide unused variable

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [net-next PATCH] tcp: md5: hide unused variable
Date 2017-06-21 18:40 +0200
Message-ID <tUQPF-6J-53@gated-at.bofh.it> (permalink)
References <tUxN0-4P5-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 20 Jun 2017 22:11:21 +0200

> Changing from a memcpy to per-member comparison left the
> size variable unused:
> 
> net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup':
> net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable]
> 
> This does not show up when CONFIG_IPV6 is enabled, but the
> variable can be removed either way, along with the now unused
> assignment.
> 
> Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[net-next PATCH] tcp: md5: hide unused variable Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:20 +0200
  Re: [net-next PATCH] tcp: md5: hide unused variable David Miller <davem@davemloft.net> - 2017-06-21 18:40 +0200

csiph-web