Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Clemens Gruber <clemens.gruber@pqgruber.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP
Date	Wed, 21 Jun 2017 16:10:01 +0200
Message-ID	<tUOut-754-3@gated-at.bofh.it> (permalink)
References	<tUtzJ-238-45@gated-at.bofh.it> <tUu2K-2t3-21@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.3 (2017-05-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	linux-serial@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Fabio Estevam <fabio.estevam@nxp.com>, Uwe Kleine-König <u.kleine-koenig@pengutronix.de>, linux-kernel <linux-kernel@vger.kernel.org>, Fugang Duan <fugang.duan@nxp.com>
X-Original-Date	Wed, 21 Jun 2017 16:05:56 +0200
X-Original-Message-ID	<20170621140556.GA766@archie.localdomain>
X-Original-References	<20170620153701.12626-1-clemens.gruber@pqgruber.com> <CAOMZO5Djf8OsqF=jUBo1Dkm2mw7pObxmkC=qq0U0RLZsYonXgQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1671692

Show key headers only | View raw

Hi Fabio,

On Tue, Jun 20, 2017 at 01:13:18PM -0300, Fabio Estevam wrote:
> The subject gives the impression that the DMA will only be disabled
> for RS485, but the impact of this change is wider.
> 
> For example: if I have a mx6q system with a Bluetooth serial
> connection I can no longer use DMA with your change applied.
> 
> Ideally we should fix the RS485 DMA bug. If that is not possible, then
> at least we need to restrict this change to the RS485 case.
> 
> Maybe we need to pass "linux,rs485-enabled-at-boot-time" in device
> tree and then use this property to deceide if DMA will be enabled or
> not:
> 
> if (!uart_console(port) && !sport->dma_is_inited && !sport->rs485_enabled)

I'd also prefer fixing the underlying problem.
If you take a look at the DMA parts in drivers/tty/serial/imx.c, can you
spot anything SMP-unsafe?
By the way, can you get your hands on an i.MX6Q board with RS-485 to
reproduce it?

We could try for a few more weeks to find the bug and if we don't find
it, adding this rs485-enabled-at-boot-time property sounds good!

Thanks,
Clemens

Thread

[PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-06-20 17:50 +0200
  Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Fabio Estevam <festevam@gmail.com> - 2017-06-20 18:20 +0200
    Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Fabio Estevam <festevam@gmail.com> - 2017-06-21 01:50 +0200
      Re: serial: imx: disable DMA for RS-485 on i.MX6 SMP Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-07-02 22:50 +0200
        Re: serial: imx: disable DMA for RS-485 on i.MX6 SMP Fabio Estevam <festevam@gmail.com> - 2017-07-03 01:10 +0200
    Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-06-21 16:10 +0200
      Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Fabio Estevam <festevam@gmail.com> - 2017-06-21 16:20 +0200
        Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Fabio Estevam <festevam@gmail.com> - 2017-06-30 14:20 +0200
          Re: [PATCH] serial: imx: disable DMA for RS-485 on i.MX6 SMP Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-07-02 22:20 +0200
  AW: [Customers.Eckelmann] [PATCH] serial: imx: disable DMA for  RS-485 on i.MX6 SMP "Schenk, Gavin" <G.Schenk@eckelmann.de> - 2017-06-23 11:40 +0200

csiph-web