Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671667

[PATCH][net-next] qtnfmac: fix uninitialized return code in ret

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The return value ret is unitialized and garbage is being returned
for the three different error conditions when setting up the PCIe
BARs. Fix this by initializing ret to  -ENOMEM to indicate that
the BARs failed to be setup correctly.

Detected by CoverityScan, CID#1437563 ("Unitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
index f93b27f3a236..7fc4f0d6a9ad 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
@@ -247,7 +247,7 @@ static void qtnf_pcie_free_shm_ipc(struct qtnf_pcie_bus_priv *priv)
 
 static int qtnf_pcie_init_memory(struct qtnf_pcie_bus_priv *priv)
 {
-	int ret;
+	int ret = -ENOMEM;
 
 	priv->sysctl_bar = qtnf_map_bar(priv, QTN_SYSCTL_BAR);
 	if (IS_ERR_OR_NULL(priv->sysctl_bar)) {
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] qtnfmac: fix uninitialized return code in ret Colin King <colin.king@canonical.com> - 2017-06-21 15:30 +0200
  Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret Colin Ian King <colin.king@canonical.com> - 2017-06-21 16:00 +0200
  Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-22 07:20 +0200
  Re: [net-next] qtnfmac: fix uninitialized return code in ret Kalle Valo <kvalo@codeaurora.org> - 2017-06-28 20:00 +0200

csiph-web