Re: [PATCH] drm/arm: hdlcd: remove unused variables

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/arm: hdlcd: remove unused variables
Date	2017-06-21 10:50 +0200
Message-ID	<tUJuO-3Nw-17@gated-at.bofh.it> (permalink)
References	<tUy6l-4Vv-7@gated-at.bofh.it> <tUJ1M-3E2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 21, 2017 at 10:16 AM, Liviu Dudau <liviu.dudau@arm.com> wrote:
> Hi Arnd,
>
> On Tue, Jun 20, 2017 at 10:30:38PM +0200, Arnd Bergmann wrote:
>> The last rework left behind two unused variables:
>>
>> drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update':
>> drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y' [-Wunused-variable]
>> drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x' [-Wunused-variable]
>>
>> This removes them.
>
> Thanks for the patch! Acked-by: Liviu Dudau <liviu.dudau@arm.com>
>
> This is starting to get embarrassing :) I'm not sure why I didn't see the warnings when
> I did my builds, but I would like to make changes so that in the future I can catch
> situations like this. Do you change the flags of the default make multi_v7_defconfig?

I mainly do randconfig testing, which catches a lot of bugs that you don't
see in the defconfig build. My general recommendation is to build-test on
ARM allmodconfig and x86 allmodconfig, and to ensure that all new code
gets enabled with CONFIG_COMPILE_TEST in those builds.

> I will apply the patch to the HLDCD tree and send Dave an updated pull request.

Ok, thanks!

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/arm: hdlcd: remove unused variables Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:40 +0200
  Re: [PATCH] drm/arm: hdlcd: remove unused variables Liviu Dudau <liviu.dudau@arm.com> - 2017-06-21 10:20 +0200
    Re: [PATCH] drm/arm: hdlcd: remove unused variables Arnd Bergmann <arnd@arndb.de> - 2017-06-21 10:50 +0200

csiph-web