Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1671528

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

From Benjamin Gaignard <benjamin.gaignard@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 00/51] rtc: stop using rtc deprecated functions
Date 2017-06-21 11:20 +0200
Message-ID <tUJXR-4eI-33@gated-at.bofh.it> (permalink)
References (5 earlier) <tUrxT-Mz-5@gated-at.bofh.it> <tUrHA-Q2-25@gated-at.bofh.it> <tUrHA-Q2-23@gated-at.bofh.it> <tUsX0-1Ny-17@gated-at.bofh.it> <tUzvs-5W2-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2017-06-21 0:08 GMT+02:00 Pavel Machek <pavel@ucw.cz>:
> Hi!
>
>> >> > This is it.
>> >> > https://patchwork.kernel.org/patch/6219401/
>> >>
>> >> Thanks.
>> >>
>> >> Yes, that's argument against changing rtc _drivers_ for hardware that
>> >> can not do better than 32bit. For generic code (such as 44/51 sysfs,
>> >> 51/51 suspend test), the change still makes sense.
>>
>> What I had in mind when writing those patches was to remove the limitations
>> coming from those functions usage, even more since they been marked has
>> deprecated.
>>
>> I agree that will change nothing of hardware limitation but at least
>> the limit will
>> not come from the framework.
>
>> > Yes, we agree on that but I won't cherry pick working patches from a 51
>> > patches series.
>
> Well, it would be actually nice for you to do the cherry
> picking. That's something maintainers do, because it is hard for
> contributors to guess maintainer's taste.
>
> Anyway, it looks like someone should go through all the RTC drivers,
> and document their limitations of each driver (date in future when
> hardware ceases to be useful). If Benjamin has time to do that, I
> guess that removes all the objections to the series.

Without the datasheet I can check in driver code what they do in read/set
time functions to understand their limitations. All drivers using BCD
like system
or spliting day and time should be fixed. I can do a subset of my patches
including those driver + the acked ones.

Alexandre does that sound reasonable for you ?


> Regards,
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/51] rtc: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-20 12:10 +0200
  [PATCH 02/51] x86: intel-mid: vrtc: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-20 12:10 +0200
  Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-20 12:10 +0200
  [PATCH 03/51] net: broadcom: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-20 12:10 +0200
  Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-20 12:10 +0200
    Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Pavel Machek <pavel@ucw.cz> - 2017-06-20 14:20 +0200
      Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-20 14:30 +0200
        Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Pavel Machek <pavel@ucw.cz> - 2017-06-20 15:30 +0200
          RE: [PATCH 00/51] rtc: stop using rtc deprecated functions Steve Twiss <stwiss.opensource@diasemi.com> - 2017-06-20 15:40 +0200
            Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-20 15:50 +0200
              Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-20 17:10 +0200
                Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-20 23:20 +0200
                RE: [PATCH 00/51] rtc: stop using rtc deprecated functions David Laight <David.Laight@ACULAB.COM> - 2017-06-21 11:30 +0200
                Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-21 11:40 +0200
                Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Pavel Machek <pavel@ucw.cz> - 2017-06-21 00:10 +0200
                Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-21 11:20 +0200
            Re: [PATCH 00/51] rtc: stop using rtc deprecated functions Pavel Machek <pavel@ucw.cz> - 2017-06-20 15:50 +0200

csiph-web