Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671302

[PATCH v2] mm: Drop useless local parameters of __register_one_node()

Show all headers | View raw

... initializes local parameters "p_node" & "parent" for
register_node().

But, register_node() does not use them.

Remove the related code of "parent" node, cleanup __register_one_node()
and register_node().

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: isimatu.yasuaki@jp.fujitsu.com
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
---
V1 --> V2:
Rebase it on 
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm

 drivers/base/node.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 73d39bc..d8dc830 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -288,7 +288,7 @@ static void node_device_release(struct device *dev)
  *
  * Initialize and register the node device.
  */
-static int register_node(struct node *node, int num, struct node *parent)
+static int register_node(struct node *node, int num)
 {
 	int error;
 
@@ -567,19 +567,14 @@ static void init_node_hugetlb_work(int nid) { }
 
 int __register_one_node(int nid)
 {
-	int p_node = parent_node(nid);
-	struct node *parent = NULL;
 	int error;
 	int cpu;
 
-	if (p_node != nid)
-		parent = node_devices[p_node];
-
 	node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL);
 	if (!node_devices[nid])
 		return -ENOMEM;
 
-	error = register_node(node_devices[nid], nid, parent);
+	error = register_node(node_devices[nid], nid);
 
 	/* link cpu under this node */
 	for_each_present_cpu(cpu) {
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] mm: Drop useless local parameters of __register_one_node() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-06-21 05:00 +0200
  Re: [PATCH v2] mm: Drop useless local parameters of  __register_one_node() Michal Hocko <mhocko@kernel.org> - 2017-06-29 13:20 +0200
    Re: [PATCH v2] mm: Drop useless local parameters of  __register_one_node() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-06-29 14:00 +0200
      Re: [PATCH v2] mm: Drop useless local parameters of  __register_one_node() Michal Hocko <mhocko@kernel.org> - 2017-06-29 14:20 +0200

csiph-web