Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

From	l00371289 <linyunsheng@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test
Date	2017-06-21 04:10 +0200
Message-ID	<tUDfH-8jH-1@gated-at.bofh.it> (permalink)
References	<tSVgK-6bj-17@gated-at.bofh.it> <tUc5Q-7Wx-21@gated-at.bofh.it> <tUcSd-8dc-3@gated-at.bofh.it> <tUhRT-37F-3@gated-at.bofh.it> <tUrod-Jj-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Andrew

On 2017/6/20 21:28, Andrew Lunn wrote:
>>>> The question really is, why is not this properly integrated into the PHY
>>>> driver and PHYLIB such that the only thing the Ethernet MAC driver has
>>>> to call is a function of the PHY driver putting it in self-test?
>>>
>>> This whole driver pokes various PHY registers, rather than use
>>> phylib. And it does so without taking the PHY lock. 
>> I will consider using phylib as much as possible, thanks.
>>
>> It also assumes it
>>> is a Marvell PHY and i don't see anywhere it actually verifies this.
>> When it said Marvell Phy , I meant Marvell Phy with fibre support.
>> I will send anther patch to only setting bit in Fiber Control when
>> it is a Marvell Phy with fibre support.
> 
> There is a lot more broken than just that.
> 
> You really should remove all code which is accessing the PHY, and add
> support to phylib and the drivers for what you need.
> 
>     Andrew
After adding genphy_loopback support, I will try it. Thanks for pointing out.

Best Regards
Yunsheng Lin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test l00371289 <linyunsheng@huawei.com> - 2017-06-20 05:20 +0200
  Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test Andrew Lunn <andrew@lunn.ch> - 2017-06-20 15:30 +0200
    Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test l00371289 <linyunsheng@huawei.com> - 2017-06-21 04:10 +0200

csiph-web