Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller

From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller
Date	2017-06-21 04:40 +0200
Message-ID	<tUDIK-9t-3@gated-at.bofh.it> (permalink)
References	<tOZ9g-2Na-7@gated-at.bofh.it> <tQpXI-LP-21@gated-at.bofh.it> <tRqRI-6Wp-7@gated-at.bofh.it> <tUnDZ-6Ll-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20 June 2017 at 17:10, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jun 12, 2017 at 8:07 AM, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
>
>> I agree we should add these into core code, something like:
>> static const struct pinconf_generic_params dt_params[] = {
> (...)
>>         { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 },
>> +       { "sleep-bias-pull-up", PIN_CONFIG_SLEEP_BIAS_PULL_UP, 1},
>> +       { "sleep-bias-pull-down", PIN_CONFIG_SLEEP_BIAS_PULL_DOWN 1},
>>         ......
>> };
>>
>> If you agree that, I can help to add these configuration.
>
> Actually, yes indeed, that is a nice thing. Very nice. I think my Nomadik
> driver could use this too.
>
> Just need to hear what the DT maintainers have to say about it.

OK, I will submit one patch to review. Thanks.

-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for  Spreadtrum pin controller Linus Walleij <linus.walleij@linaro.org> - 2017-06-20 11:30 +0200
  Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for  Spreadtrum pin controller Baolin Wang <baolin.wang@linaro.org> - 2017-06-21 04:40 +0200

csiph-web