Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671233

Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

Show all headers | View raw

On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote:
> The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages
> to netdev_dbg and adds a netdev debug for the packets per slave parameter.

Hey Michael.

You should realign the multiple-line statements
to the open parentheses.

cheers, Joe

> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
[]
> @@ -721,13 +721,13 @@ static int bond_option_mode_set(struct bonding *bond,
>  				const struct bond_opt_value *newval)
>  {
>  	if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) {
> -		netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
> +		netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
>  			    newval->string);

Now all these are not aligned properly.

etc...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg Michael J Dilmore <michael.j.dilmore@gmail.com> - 2017-06-21 00:10 +0200
  Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple  netdev_info messages to netdev_dbg Joe Perches <joe@perches.com> - 2017-06-21 01:30 +0200

csiph-web