Re: [PATCH] tty: hide unused pty_get_peer function

From	Aleksa Sarai <asarai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: hide unused pty_get_peer function
Date	2017-06-21 01:20 +0200
Message-ID	<tUABc-6zP-27@gated-at.bofh.it> (permalink)
References	<tUy6m-4Vv-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> TIOCGPTPEER is only used for unix98 PTYs, and we get a warning
> when those are disabled:
> 
> drivers/tty/pty.c:466:12: error: 'pty_get_peer' defined but not used [-Werror=unused-function]
> 
> This moves the respective functions inside of the existing #ifdef.
> 
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Oops, I missed that.

   Acked-by: Aleksa Sarai <asarai@suse.de>

-- 
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty: hide unused pty_get_peer function Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:40 +0200
  Re: [PATCH] tty: hide unused pty_get_peer function Kees Cook <keescook@chromium.org> - 2017-06-21 00:40 +0200
  Re: [PATCH] tty: hide unused pty_get_peer function Aleksa Sarai <asarai@suse.de> - 2017-06-21 01:20 +0200

csiph-web