Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669646

Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by misplaced __printf

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by misplaced __printf
Date 2017-06-19 20:50 +0200
Message-ID <tU9Um-6lI-27@gated-at.bofh.it> (permalink)
References <tT5zr-4Er-5@gated-at.bofh.it> <tU97Y-5OJ-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Em Mon, Jun 19, 2017 at 11:51:20AM -0600, Mathieu Poirier escreveu:
> On 16 June 2017 at 13:59, Kim Phillips <kim.phillips@arm.com> wrote:
> > -static int cs_device__print_file(const char *name, const char *fmt, ...) __printf(2, 3)
> > +static int __printf(2, 3) cs_device__print_file(const char *name, const char *fmt, ...)
> >  {
> >         va_list args;
> >         FILE *file;
> 
> I just tested Kim's solution on my side.
> 
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks for checking, since I haven't pushed this to Ingo I just squashed
Kim's fix into the buggy cset.

Now I'm trying to build it with lots of cross build containers to see if
there are any other problems before push this up to Ingo.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by  misplaced __printf Kim Phillips <kim.phillips@arm.com> - 2017-06-16 22:00 +0200
  Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused  by misplaced __printf Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-06-19 20:00 +0200
    Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused  by misplaced __printf Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 20:50 +0200
      Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds  caused by misplaced __printf Kim Phillips <kim.phillips@arm.com> - 2017-06-19 21:30 +0200
        Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused  by misplaced __printf Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 22:00 +0200
          Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds  caused by misplaced __printf Kim Phillips <kim.phillips@arm.com> - 2017-06-19 22:30 +0200

csiph-web