Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669619

Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready flag

Show all headers | View raw

On 06/19/2017 01:24 PM, Brüns, Stefan wrote:
> On Mittwoch, 24. Mai 2017 21:56:54 CEST Jonathan Cameron wrote:
>> On Wed, 24 May 2017 20:53:35 +0100
>>
>> Jonathan Cameron <jic23@kernel.org> wrote:
>>> On Wed, 24 May 2017 02:09:07 +0200
>>>
>>> Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
>>>> While the INA226 has a conversion ready flag (CVRF) in the R/W
>>>> Mask/Enable
>>>> register with read-to-clear semantics, the corresponding bit of the
>>>> INA219
>>>> (CNVR) is part of the bus voltage register. The flag is cleared by
>>>> reading
>>>> the power register.
>>>>
>>>> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
>>>
>>> Again, looks good to me, but I would like input form Marc or Andrew
>>> who are more familiar with these devices than me!
>>>
>>> Ping me in a week or two if nothing is happening and I look to have
>>> lost these!
>>
>> Ah Marc's old email is bouncing.  If no one has a more up to
>> data address I guess we'll be looking at Andrew to have a chance to
>> respond (which is more likely if I actually cc him ;)
> 
> Ping ;-)
> 

As for me, my silence is approval, nothing looks incorrect to me.

> Kind regards,
> 
> Stefan
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready  flag Brüns, Stefan <Stefan.Bruens@rwth-aachen.de> - 2017-06-19 20:30 +0200
  Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready  flag "Andrew F. Davis" <afd@ti.com> - 2017-06-19 20:40 +0200
    Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready  flag Jonathan Cameron <jic23@kernel.org> - 2017-06-21 21:30 +0200

csiph-web