Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669532
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation |
| Date | 2017-06-19 19:30 +0200 |
| Message-ID | <tU8EW-5CR-11@gated-at.bofh.it> (permalink) |
| References | <tT9tn-7uo-3@gated-at.bofh.it> <tT9to-7uo-15@gated-at.bofh.it> <tU8EW-5CR-13@gated-at.bofh.it> <tU8EW-5CR-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/19/2017 08:18 AM, Yury Norov wrote: > On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote: >> Hi Florian, >> >> Some questions and thoughts inline. >> >> Yury >> >> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: >>> Define a generic fncpy() implementation largely based on the ARM version >>> that requires an 8 bytes alignment for the destination address where to >>> copy this function as well as the function's own address. >>> >>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >>> --- >>> include/asm-generic/fncpy.h | 93 +++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 93 insertions(+) >>> create mode 100644 include/asm-generic/fncpy.h > > One else thing I forgot to ask - now you have the generic > implementation for fncpy(), so do you really need to save arm > version of it? Yes, it needs to deal with the Thumb bit, and there is no point in making the generic implementation extremely flexible to support that special case. Thanks -- Florian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Florian Fainelli <f.fainelli@gmail.com> - 2017-06-17 02:10 +0200 Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Florian Fainelli <f.fainelli@gmail.com> - 2017-06-19 19:30 +0200 Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-19 19:50 +0200 Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Florian Fainelli <florian.fainelli@broadcom.com> - 2017-06-19 23:00 +0200
csiph-web