Re: [PATCH 1/3] livepatch: introduce shadow variable API

From	Miroslav Benes <mbenes@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] livepatch: introduce shadow variable API
Date	2017-06-19 18:20 +0200
Message-ID	<tU7zd-4Y3-45@gated-at.bofh.it> (permalink)
References	<tND17-68x-3@gated-at.bofh.it> <tND18-68x-11@gated-at.bofh.it> <tSg3U-5hv-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > +struct klp_shadow {
> > +	struct hlist_node node;
> > +	struct rcu_head rcu_head;
> > +	void *obj;
> > +	char *var;
> > +	void *data;
> 
> I would make the meaning more obvious. What about renaming?
> 
>   var -> key or id
>   data -> shadow_obj or new_obj

But var is not a key to a hash table. obj is. Renaming obj to key would be 
misleading in my opinion, because it IS a pointer to an object. And data 
is ok too, as far as I'm concerned. Just saying.

But yes, I'd welcome a description too.

Miroslav

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] livepatch: introduce shadow variable API Petr Mladek <pmladek@suse.com> - 2017-06-14 15:00 +0200
  Re: [PATCH 1/3] livepatch: introduce shadow variable API Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-14 15:20 +0200
    Re: [PATCH 1/3] livepatch: introduce shadow variable API Petr Mladek <pmladek@suse.com> - 2017-06-14 16:30 +0200
  Re: [PATCH 1/3] livepatch: introduce shadow variable API Miroslav Benes <mbenes@suse.cz> - 2017-06-19 18:20 +0200

csiph-web