Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669424

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions
Date 2017-06-19 18:10 +0200
Message-ID <tU7py-4Ul-77@gated-at.bofh.it> (permalink)
References <tSe25-459-3@gated-at.bofh.it> <tSe27-459-47@gated-at.bofh.it> <tSfAS-57e-13@gated-at.bofh.it> <tSgdz-5BT-1@gated-at.bofh.it> <tU7fP-4Bo-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 19, 2017 at 6:58 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> Believe me I've looked for mistakes like this but I've read the code so many
>> times I don't think I can see the obvious anymore.
>
> Yes, I know this. And you worked hard on this slave feature,
> acknowledged.
>
> Patches 1-4 look good to me from what I glimpsed. I largely trust here
> the *much* appreciated review from Jarkko and Andy. Thanks a lot, guys!
>
> I wonder if we haven't reached a state where Luis just could fix the
> buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by
> Andy and we handle further small fixes incrementally during the v4.13
> cycle? AFAICS there is no major show-stopper, or am I wrong?

I would go with the following plan:
1. Push 1-4
2. Resend 5-6 with addressed pointed issues for one more (fast) round

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-06-14 12:50 +0200
  Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-14 14:30 +0200
    Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-06-14 15:10 +0200
      Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Wolfram Sang <wsa@the-dreams.de> - 2017-06-19 18:00 +0200
        Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-19 18:10 +0200
          Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-06-19 18:20 +0200
          Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Wolfram Sang <wsa@the-dreams.de> - 2017-06-19 18:30 +0200

csiph-web