Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1669344

Re: [PATCH V1] one wire ds1wm patch

From Greg Kroah-Hartman <greg@kroah.com>
Newsgroups linux.kernel
Subject Re: [PATCH V1] one wire ds1wm patch
Date 2017-06-19 17:40 +0200
Message-ID <tU6Wz-4tx-143@gated-at.bofh.it> (permalink)
References <tU3lX-25Y-91@gated-at.bofh.it> <tU6jO-3YD-57@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 19, 2017 at 05:55:12PM +0300, Evgeniy Polyalkov wrote:
> Hi
> 
> 19.06.2017, 14:38, "Johannes Pöhlmann" <johannes.poehlmann@izt-labs.de>:
> > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit)
> > with a register offset multiplier of 4 i had to make some changes to
> >
> >           drivers/w1/masters/ds1wm.c
> > and include/linux/mfd/ds1wm.h.
> >
> > I grouped theses into 4 patches of falling priority.
> >
> > [PATCH 1/4] fix and simplify register access
> > [PATCH 2/4] Add level interrupt modes (maybe no longer needed in newer
> > kernels)
> > [PATCH 3/4] Silence interrupts on HW before claiming the interrupt
> > [PATCH 4/4] optional: add messages to make incorporation in mfd drivers
> > easier
> 
> Patches look good, thank you.

No they do not, they need to be sent in the correct format, with the
correct signed-off-by, and all of the needed information...

> Greg, please pull them into your tree, is it ok to be sent as attachment?

Not at all.

> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Johannes, please fix up and resend and add Evgeniy's acked-by to the
patchs and I will be glad to take them.  Please read
Documentation/SubmittingPatches for the correct format to use.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V1] one wire ds1wm patch Johannes Pöhlmann <johannes.poehlmann@izt-labs.de> - 2017-06-19 13:50 +0200
  Re: [PATCH V1] one wire ds1wm patch Evgeniy Polyalkov <zbr@ioremap.net> - 2017-06-19 17:00 +0200
    Re: [PATCH V1] one wire ds1wm patch Greg Kroah-Hartman <greg@kroah.com> - 2017-06-19 17:40 +0200
  Re: [PATCH V1] one wire ds1wm patch kbuild test robot <lkp@intel.com> - 2017-06-19 19:40 +0200

csiph-web