Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock

From	Neil Armstrong <narmstrong@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock
Date	2017-06-19 10:50 +0200
Message-ID	<tU0xI-jE-27@gated-at.bofh.it> (permalink)
References	<tSbQD-2Ni-35@gated-at.bofh.it> <tSbQD-2Ni-33@gated-at.bofh.it> <tT6vv-5g1-13@gated-at.bofh.it>
Organization	Baylibre

Show all headers | View raw

On 06/16/2017 10:57 PM, Kevin Hilman wrote:
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
>> From: Helmut Klein <hgkr.klein@gmail.com>
>>
>> This patch switches to the stable UART bindings but also add the correct
>> gate clock to the non-AO UART nodes for GXBB and GXL SoCs.
>>
>> Acked-by: Jerome Brunet <jbrunet@baylibre.com>
>> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi   | 12 +++++-------
>>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 25 +++++++++++++++++++++++++
>>  arch/arm64/boot/dts/amlogic/meson-gxl.dtsi  | 25 +++++++++++++++++++++++++
>>  3 files changed, 55 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 603491d..86a4018 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -225,7 +225,7 @@
>>  			};
>>  
>>  			uart_A: serial@84c0 {
>> -				compatible = "amlogic,meson-uart";
>> +				compatible = "amlogic,meson-gx-uart";
> 
> IMO, we should keep both compatibles (the more specific one first.)
> That would allow new DTs to continue to run on older kernels.
> 
> It would also allow this DT change to be completely independent of the
> driver changes.  Otherwise, if I merge this before the driver change are
> merged, we'll have a bunch of boards with no more serial console output.
> 
> Kevin
> 

Hi Kevin,

Sure, no problem with that.

I'll push an update when the bindings + tty fixes are merged somewhere.

Neil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Neil Armstrong <narmstrong@baylibre.com> - 2017-06-14 10:30 +0200
  Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Kevin Hilman <khilman@baylibre.com> - 2017-06-16 23:00 +0200
    Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings  with correct gate clock Neil Armstrong <narmstrong@baylibre.com> - 2017-06-19 10:50 +0200

csiph-web