Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1668892
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t |
| Date | 2017-06-19 10:30 +0200 |
| Message-ID | <tU0el-dh-13@gated-at.bofh.it> (permalink) |
| References | <tTEQy-3lF-1@gated-at.bofh.it> <tTEQy-3lF-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Jun 18, 2017 at 09:58:27AM +0100, Okash Khawaja wrote:
> +int ser_to_dev(int ser, dev_t *dev_no)
> +{
> + if (ser < 0 || ser > (255 - 64)) {
> + pr_err("speakup: Invalid ser param. \
> + Must be between 0 and 191 inclusive.\n");
I pointed out that all these strings are wrong in the first version of
the patch. You're going to end up with a whole bunch of tabs in your
dmesg output.
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch v2 0/3] staging: speakup: support more than ttyS* Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-18 11:40 +0200
[patch v2 3/3] staging: speakup: make ttyio synths use device name Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-18 11:40 +0200
Re: [patch v2 3/3] staging: speakup: make ttyio synths use device name Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-18 15:40 +0200
[patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-18 11:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-18 15:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-18 19:30 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-18 22:00 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Joe Perches <joe@perches.com> - 2017-06-19 02:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-19 03:20 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-19 07:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-19 07:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Joe Perches <joe@perches.com> - 2017-06-19 07:40 +0200
Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-19 10:30 +0200
[patch v2 1/3] tty: add function to convert device name to number Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-18 11:40 +0200
Re: [patch v2 1/3] tty: add function to convert device name to number Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-18 15:30 +0200
Re: [patch v2 1/3] tty: add function to convert device name to number Okash Khawaja <okash.khawaja@gmail.com> - 2017-06-19 10:10 +0200
csiph-web