Re: [PATCH 23/28] mbcache: make mbcache more generic

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 23/28] mbcache: make mbcache more generic
Date	2017-06-19 11:00 +0200
Message-ID	<tU0Ho-n6-21@gated-at.bofh.it> (permalink)
References	<tN71f-2f2-7@gated-at.bofh.it> <tN7aW-2iQ-17@gated-at.bofh.it> <tSxHr-85z-9@gated-at.bofh.it> <tSHGO-5Wn-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 15-06-17 11:25:02, Tahsin Erdogan wrote:
> On Thu, Jun 15, 2017 at 12:41 AM, Jan Kara <jack@suse.cz> wrote:
> > Can you explain a bit more what do you mean by "make it more generic" as it
> > seems you just rename a couple of things here...
> 
> The change is really just that, having names that are more generic
> which do not limit use cases to block sharing. In a subsequent patch
> in the series ("[PATCH v4 27/28] ext4: xattr inode deduplication"), we
> start using the mbcache code to share xattr inodes. With that patch,
> old mb_cache_entry.e_block field could be holding either a block
> number or an inode number, so I renamed things to make them more
> generic.

OK, then I'd suggest to change title to "mbcache: make mbcache naming more
generic" and explain what you wrote here in the changelog. Thanks!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 23/28] mbcache: make mbcache more generic Jan Kara <jack@suse.cz> - 2017-06-15 09:50 +0200
  Re: [PATCH 23/28] mbcache: make mbcache more generic Tahsin Erdogan <tahsin@google.com> - 2017-06-15 20:30 +0200
    Re: [PATCH 23/28] mbcache: make mbcache more generic Jan Kara <jack@suse.cz> - 2017-06-19 11:00 +0200

csiph-web