Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1668498

[PATCH 2/3] selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGS

From SeongJae Park <sj38.park@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGS
Date 2017-06-18 03:00 +0200
Message-ID <tTwJj-6yj-7@gated-at.bofh.it> (permalink)
References <tTwJj-6yj-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Build of aperf fails as below:
```
gcc  -Wall -D_GNU_SOURCE   -lm  aperf.c  -o /tools/testing/selftests/intel_pstate/aperf
/tmp/ccKf3GF6.o: In function `main':
aperf.c:(.text+0x278): undefined reference to `sqrt'
collect2: error: ld returned 1 exit status
```

The faulure occurs because -lm was defined as LDFLAGS and implicit rule
of make places LDFLAGS before source file.  This commit fixes the
problem by using LDLIBS instead of LDFLAGS.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/intel_pstate/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/intel_pstate/Makefile b/tools/testing/selftests/intel_pstate/Makefile
index 19678e90efb2..849a90ffe8dd 100644
--- a/tools/testing/selftests/intel_pstate/Makefile
+++ b/tools/testing/selftests/intel_pstate/Makefile
@@ -1,5 +1,5 @@
 CFLAGS := $(CFLAGS) -Wall -D_GNU_SOURCE
-LDFLAGS := $(LDFLAGS) -lm
+LDLIBS := $(LDLIBS) -lm
 
 TEST_GEN_FILES := msr aperf
 
-- 
2.13.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 2/3] selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGS SeongJae Park <sj38.park@gmail.com> - 2017-06-18 03:00 +0200

csiph-web