Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1668382
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC |
| Date | 2017-06-17 20:00 +0200 |
| Message-ID | <tTqaS-23R-5@gated-at.bofh.it> (permalink) |
| References | <tTpHP-1Qt-1@gated-at.bofh.it> <tTpHQ-1Qt-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> +static int hns3_nic_net_up(struct net_device *ndev)
> +{
> + struct hns3_nic_priv *priv = netdev_priv(ndev);
> + struct hnae3_handle *h = priv->ae_handle;
> + int i, j;
> + int ret;
> +
> + ret = hns3_nic_init_irq(priv);
> + if (ret != 0) {
if (ret)
No need to compare with zero.
> + netdev_err(ndev, "hns init irq failed! ret=%d\n", ret);
> + return ret;
> +static int hns3_nic_net_open(struct net_device *ndev)
> +{
> + struct hns3_nic_priv *priv = netdev_priv(ndev);
> + struct hnae3_handle *h = priv->ae_handle;
> + int ret;
> +
> + netif_carrier_off(ndev);
> +
> + ret = netif_set_real_num_tx_queues(ndev, h->kinfo.num_tqps);
> + if (ret < 0) {
> + netdev_err(ndev, "netif_set_real_num_tx_queues fail, ret=%d!\n",
> + ret);
> + return ret;
> + }
In general, functions return 0 for success, and something else for an
error. So there is no need to do a comparison. Please remove all
comparisons, unless it is really needed. It also makes the code look
consistent. At the moment you sometime have < 0, sometime !=0, and
sometimes no comparison at all.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V3 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
[PATCH V3 net-next 3/8] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
[PATCH V3 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
[PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework Andrew Lunn <andrew@lunn.ch> - 2017-06-17 21:50 +0200
Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework Andrew Lunn <andrew@lunn.ch> - 2017-06-18 17:10 +0200
Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework Bo Yu <tsu.yubo@gmail.com> - 2017-06-18 18:50 +0200
Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework Stephen Hemminger <stephen@networkplumber.org> - 2017-06-19 19:00 +0200
[PATCH V3 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
[PATCH V3 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
Re: [PATCH V3 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Andrew Lunn <andrew@lunn.ch> - 2017-06-19 06:00 +0200
[PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 19:30 +0200
Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Richard Cochran <richardcochran@gmail.com> - 2017-06-18 18:50 +0200
Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Andrew Lunn <andrew@lunn.ch> - 2017-06-17 20:00 +0200
Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Andrew Lunn <andrew@lunn.ch> - 2017-06-17 21:50 +0200
Re: [PATCH V3 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver Leon Romanovsky <leon@kernel.org> - 2017-06-18 08:10 +0200
Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Bo Yu <tsu.yubo@gmail.com> - 2017-06-18 19:00 +0200
csiph-web