Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1668265

Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5]

Show all headers | View raw

On Sat, 2017-06-17 at 15:18 +0100, David Howells wrote:
> Theodore Ts'o <tytso@mit.edu> wrote:
> 
> > I don't know that this is a hard and fast rule.  Struct bio uses a
> > "bi_" prefix (e.g., bi_error, bi_opf, bi_iter, etc.).
> 
> Linus told me to stop doing it.
> 
> David


That's a pity... I tend to like little prefixes on fields too. Trying to
find all occurrences of a symbol called "flags" in cscope is a losing
exercise.

Do you have a reference to the discussion so I can understand the
rationale there?

Thanks,
-- 
Jeff Layton <jlayton@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 00/27] VFS: Introduce filesystem context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 11/27] VFS: Remove unused code after filesystem context  changes [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 20/27] NFS: Split nfs_parse_mount_options() [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 03/27] VFS: Make get_mnt_ns() return the namespace [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
    Re: [PATCH 03/27] VFS: Make get_mnt_ns() return the namespace [ver  #5] Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-15 11:20 +0200
  [PATCH 27/27] kernfs, sysfs, cgroup: Support fs_context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
    Re: [PATCH 27/27] kernfs, sysfs, cgroup: Support fs_context [ver #5] Tejun Heo <tj@kernel.org> - 2017-06-14 20:00 +0200
    Re: [PATCH 27/27] ... and the intel_rdt driver David Howells <dhowells@redhat.com> - 2017-06-15 00:40 +0200
  [PATCH 26/27] cpuset: Use fs_context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 16/27] proc: Add fs_context support to procfs [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
    Re: [PATCH 16/27] proc: Add fs_context support to procfs [ver #5] Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-15 12:20 +0200
  [PATCH 01/27] Provide a function to create a NUL-terminated string  from unterminated data [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 09/27] VFS: Add LSM hooks for filesystem context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 25/27] ipc: Convert mqueue fs to fs_context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
    Re: [PATCH 25/27] ipc: Convert mqueue fs to fs_context [ver #5] Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-15 12:10 +0200
      Re: [PATCH 25/27] ipc: Convert mqueue fs to fs_context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-15 16:50 +0200
  [PATCH 23/27] NFS: Do some tidying of the parsing code [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 22/27] NFS: Add a small buffer in nfs_fs_context to avoid  string dup [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 14/27] VFS: Add a sample program for fsopen/fsmount [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 02/27] VFS: Clean up whitespace in fs/namespace.c and  fs/super.c [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 04/27] VFS: Make get_filesystem() return the affected  filesystem [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 18/27] NFS: Constify mount argument match tables [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:20 +0200
  [PATCH 05/27] VFS: Provide empty name qstr [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:30 +0200
  [PATCH 15/27] procfs: Move proc_fill_super() to fs/proc/root.c [ver  #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:30 +0200
  [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem  context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:30 +0200
    Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem  context [ver #5] Randy Dunlap <rdunlap@infradead.org> - 2017-06-14 20:10 +0200
      Updated docs David Howells <dhowells@redhat.com> - 2017-06-15 01:00 +0200
        Re: Updated docs Randy Dunlap <rdunlap@infradead.org> - 2017-06-15 04:00 +0200
    Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem  context [ver #5] Casey Schaufler <casey@schaufler-ca.com> - 2017-06-14 22:10 +0200
      Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 22:50 +0200
        Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem  context [ver #5] Casey Schaufler <casey@schaufler-ca.com> - 2017-06-14 23:00 +0200
          Re: [PATCH 08/27] VFS: Introduce the structs and doc for a  filesystem context [ver #5] Theodore Ts'o <tytso@mit.edu> - 2017-06-17 12:00 +0200
            Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-17 16:20 +0200
              Re: [PATCH 08/27] VFS: Introduce the structs and doc for a  filesystem context [ver #5] Jeff Layton <jlayton@redhat.com> - 2017-06-17 17:00 +0200
                Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem  context [ver #5] Randy Dunlap <rdunlap@infradead.org> - 2017-06-17 17:20 +0200
                Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5] David Howells <dhowells@redhat.com> - 2017-06-19 09:50 +0200
  [PATCH 21/27] NFS: Deindent nfs_fs_context_parse_option() [ver #5] David Howells <dhowells@redhat.com> - 2017-06-14 17:30 +0200
  Re: [PATCH 07/27] VFS: Differentiate mount flags (MS_*) from  internal superblock flags [ver #5] Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-15 11:50 +0200
    Re: [PATCH 07/27] VFS: Differentiate mount flags (MS_*) from  internal superblock flags [ver #5] Christoph Hellwig <hch@infradead.org> - 2017-06-16 11:10 +0200
      Re: [PATCH 07/27] VFS: Differentiate mount flags (MS_*) from internal superblock flags [ver #5] David Howells <dhowells@redhat.com> - 2017-06-16 17:00 +0200
        Re: [PATCH 07/27] VFS: Differentiate mount flags (MS_*) from  internal superblock flags [ver #5] Christoph Hellwig <hch@infradead.org> - 2017-06-16 18:00 +0200
          Re: [PATCH 07/27] VFS: Differentiate mount flags (MS_*) from internal superblock flags [ver #5] David Howells <dhowells@redhat.com> - 2017-06-16 18:00 +0200

csiph-web