Re: [RFC PATCH 1/2] mm: introduce bmap_walk()

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] mm: introduce bmap_walk()
Date	2017-06-17 14:30 +0200
Message-ID	<tTl1v-72O-5@gated-at.bofh.it> (permalink)
References	<tTaIN-8fC-5@gated-at.bofh.it> <tTaIN-8fC-3@gated-at.bofh.it> <tTet4-2tH-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 16, 2017 at 10:22 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Jun 16, 2017 at 06:15:29PM -0700, Dan Williams wrote:
>> Refactor the core of generic_swapfile_activate() into bmap_walk() so
>> that it can be used by a new daxfile_activate() helper (to be added).
>
> No way in hell!  generic_swapfile_activate needs to day and no new users
> of ->bmap over my dead body.  It's a guaranteed to fuck up your data left,
> right and center.

Certainly you're not saying that existing swapfiles are broken, so I
wonder what bugs you're talking about?

Unless you had plans to go remove bmap() I don't see how this gets in
your way at all. That said, I think "please don't add a new bmap()
user, use iomap instead" is a fair comment. You know me well enough to
know that would be all it takes to redirect my work, I can do without
the bluster.

Thread

[RFC PATCH 1/2] mm: introduce bmap_walk() Dan Williams <dan.j.williams@intel.com> - 2017-06-17 03:30 +0200
  Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Christoph Hellwig <hch@lst.de> - 2017-06-17 07:30 +0200
    Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Dan Williams <dan.j.williams@intel.com> - 2017-06-17 14:30 +0200
      Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Christoph Hellwig <hch@lst.de> - 2017-06-18 10:00 +0200
        Re: [RFC PATCH 1/2] mm: introduce bmap_walk() "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-06-19 18:20 +0200
        Re: [RFC PATCH 1/2] mm: introduce bmap_walk() Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-19 20:30 +0200

csiph-web