[PATCH v4 4/5] perf config: Check not only section->from_system_config but also item's

From	Taeung Song <treeze.taeung@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 4/5] perf config: Check not only section->from_system_config but also item's
Date	2017-06-17 05:50 +0200
Message-ID	<tTcUh-1gh-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Currently only section->from_system_config is being checked multiple times.
items->from_system_config should be also checked, so fix it.

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/builtin-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index a29d96e..cf8e183 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name)
 		fprintf(fp, "[%s]\n", section->name);
 
 		perf_config_items__for_each_entry(&section->items, item) {
-			if (!use_system_config && section->from_system_config)
+			if (!use_system_config && item->from_system_config)
 				continue;
 			if (item->value)
 				fprintf(fp, "\t%s = %s\n",
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v4 4/5] perf config: Check not only section->from_system_config but also item's Taeung Song <treeze.taeung@gmail.com> - 2017-06-17 05:50 +0200

csiph-web