Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1668130

Re: [PATCH 28/28] quota: add extra inode count to dquot transfer functions

Show all headers | View raw

On Thu, Jun 15, 2017 at 12:57 AM, Jan Kara <jack@suse.cz> wrote:
> Hum, rather handle this similarly to how we handle delalloc reserved space.
> Add a callback to dq_ops to get "inode usage" of an inode and then use it
> in dquot_transfer(), dquot_free_inode(), dquot_alloc_inode().

I tried that approach by adding a "int get_inode_usage(struct inode
*inode, qsize_t *usage)" callback to dquot_operations. Unfortunately,
ext4 code that calculates the number of internal inodes
(ext4_xattr_inode_count()) is subject to failures so the callback has
to be able to report errors. And, that itself is problematic because
we can't afford to have errors in dquot_free_inode(). If you have
thoughts about how to address this please let me know.

Alternatively, I could try to make this patch less intrusive by
keeping the existing dquot_transfer() signature and add a new
dquot_transfer_usage() that accepts inode_usage as a parameter. What
do you think?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 28/28] quota: add extra inode count to dquot transfer  functions Jan Kara <jack@suse.cz> - 2017-06-15 10:00 +0200
  Re: [PATCH 28/28] quota: add extra inode count to dquot transfer functions Tahsin Erdogan <tahsin@google.com> - 2017-06-17 04:00 +0200
    Re: [PATCH 28/28] quota: add extra inode count to dquot transfer  functions Jan Kara <jack@suse.cz> - 2017-06-19 11:10 +0200
      Re: [PATCH 28/28] quota: add extra inode count to dquot transfer functions Tahsin Erdogan <tahsin@google.com> - 2017-06-19 13:50 +0200
        Re: [PATCH 28/28] quota: add extra inode count to dquot transfer  functions Jan Kara <jack@suse.cz> - 2017-06-19 14:40 +0200

csiph-web