Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1668135

Re: [PATCH v4 2/5] watchdog: introduce arch_touch_nmi_watchdog()

Show all headers | View raw

On Fri, 16 Jun 2017 11:21:17 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 16 Jun 2017 16:57:12 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
> 
> > For architectures that define HAVE_NMI_WATCHDOG, instead of having
> > them provide the complete touch_nmi_watchdog() function, just have
> > them provide arch_touch_nmi_watchdog().
> > 
> > This gives the generic code more flexibility in implementing this
> > function, and arch implementations don't miss out on touching the
> > softlockup watchdog or other generic details.
> > 
> > ...
> >
> > --- a/arch/blackfin/include/asm/nmi.h
> > +++ b/arch/blackfin/include/asm/nmi.h
> > @@ -9,4 +9,6 @@
> >  
> >  #include <linux/nmi.h>
> >  
> > +extern void arch_touch_nmi_watchdog(void);  
> 
> Do we actually need to add this to the arch header files...

[snip]

> > +#if defined(CONFIG_HARDLOCKUP_DETECTOR) || defined(CONFIG_HAVE_NMI_WATCHDOG)
> > +extern void arch_touch_nmi_watchdog(void);
> > +#else
> > +static inline void arch_touch_nmi_watchdog(void) {}
> > +#endif
> > +  
> 
> given that we have a global declaration here?

Probably not. I think it was a holdover from an earlier version where
I tried to let the arch declare it (one of the little embedded ones
had a comment somewhere saying it would be nice if they could make it
inline).

There was some difficulty with it, so yes let's remove these and do
that next time.

Thanks,
Nick

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] Improve watchdog config for arch watchdogs Nicholas Piggin <npiggin@gmail.com> - 2017-06-16 09:00 +0200
  [PATCH v4 5/5] powerpc/64s: implement arch-specific hardlockup watchdog Nicholas Piggin <npiggin@gmail.com> - 2017-06-16 09:00 +0200
  [PATCH v4 2/5] watchdog: introduce arch_touch_nmi_watchdog() Nicholas Piggin <npiggin@gmail.com> - 2017-06-16 09:00 +0200
    Re: [PATCH v4 2/5] watchdog: introduce arch_touch_nmi_watchdog() Andrew Morton <akpm@linux-foundation.org> - 2017-06-16 20:30 +0200
      Re: [PATCH v4 2/5] watchdog: introduce arch_touch_nmi_watchdog() Nicholas Piggin <npiggin@gmail.com> - 2017-06-17 04:50 +0200
  [PATCH v4 3/5] watchdog: split up config options Nicholas Piggin <npiggin@gmail.com> - 2017-06-16 09:00 +0200
    Re: [PATCH v4 3/5] watchdog: split up config options Nicholas Piggin <npiggin@gmail.com> - 2017-06-17 14:40 +0200
  Re: [PATCH v4 0/5] Improve watchdog config for arch watchdogs Don Zickus <dzickus@redhat.com> - 2017-06-16 17:00 +0200
    Re: [PATCH v4 0/5] Improve watchdog config for arch watchdogs Babu Moger <babu.moger@oracle.com> - 2017-06-16 19:20 +0200

csiph-web