RE: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks

From	"Kani, Toshimitsu" <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks
Date	2017-06-17 03:00 +0200
Message-ID	<tTafL-7MV-1@gated-at.bofh.it> (permalink)
References	<tRG0p-86G-3@gated-at.bofh.it> <tSKEF-7OC-1@gated-at.bofh.it> <tT9Wp-7Ft-3@gated-at.bofh.it> <tTa65-7Jj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Fri, Jun 16, 2017 at 5:35 PM, Kani, Toshimitsu <toshi.kani@hpe.com> wrote:
> >> On Mon, Jun 12, 2017 at 3:25 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> >> > Sysfs "badblocks" information may be updated during run-time that:
> >> >  - MCE, SCI, and sysfs "scrub" may add new bad blocks
> >> >  - Writes and ioctl() may clear bad blocks
> >> >
> >> > Add support to send sysfs notifications to sysfs "badblocks" file
> >> > under region and pmem directories when their badblocks information
> >> > is re-evaluated (but is not necessarily changed) during run-time.
> >> >
> >> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> >> > Cc: Dan Williams <dan.j.williams@intel.com>
> >> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> >> > Cc: Linda Knippers <linda.knippers@hpe.com>
> >> > ---
> >> > v2: Send notifications for the clearing case
> >> > ---
> >>
> >> This looks good to me, I've applied it, but I also want to extend the
> >> ndctl unit tests to cover this mechanism.
> >
> > Right.  For the time being, would you mind to use the attached test
> > program for your sanity tests?  It simply monitors sysfs notifications
> > and prints badblocks info...  Sorry for inconvenience.
> >
> > Since I am not familiar with the ndctl unit tests and I am traveling for
> > the rest of the month, I may have to look into it after I am back.
> >
> 
> No worries, I'll take a look at integrating this. Have a nice trip!

Thanks Dan!!  I really appreciate it! 
-Toshi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks Toshi Kani <toshi.kani@hpe.com> - 2017-06-13 00:30 +0200
  Re: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks Dan Williams <dan.j.williams@intel.com> - 2017-06-15 23:40 +0200
    RE: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-17 02:40 +0200
      Re: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks Dan Williams <dan.j.williams@intel.com> - 2017-06-17 02:50 +0200
        RE: [PATCH v2] libnvdimm, pmem: Add sysfs notifications to badblocks "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-17 03:00 +0200

csiph-web