Re: [GIT PULL 0/3] perf/urgent fixes

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL 0/3] perf/urgent fixes
Date	2017-06-16 21:40 +0200
Message-ID	<tT5g5-4wK-3@gated-at.bofh.it> (permalink)
References	<tT56p-4r7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message, as usual.
> 
> The following changes since commit 63f700aab4c11d46626de3cd051dae56cf7e9056:
> 
>   Merge tag 'xtensa-20170612' of git://github.com/jcmvbkbc/linux-xtensa (2017-06-13 15:09:10 +0900)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.12-20170616
> 
> for you to fetch changes up to 9126cbbacecb8917bd0418809ef1d26616b2061e:
> 
>   perf unwind: Report module before querying isactivation in dwfl unwind (2017-06-16 14:37:30 -0300)
> 
> ----------------------------------------------------------------
> perf/urgent fixes:
> 
> - Fix probing of precise_ip level for default cycles event, that
>   got broken recently on x86_64 when its arch code started
>   considering invalid requesting precise samples when not sampling
>   (i.e. when attr.sample_period == 0).
> 
>   This also fixes another problem in s/390 where the precision
>   probing with sample_period == 0 returned precise_ip > 0, that
>   then, when setting up the real cycles event (not probing) would
>   return EOPNOTSUPP for precise_ip > 0 (as determined previously
>   by probing) and sample_period > 0.
> 
>   These problems resulted in attr_precise not being set to the
>   highest precision available on x86.64 when no event was specified,
>   i.e. the canonical:
> 
> 	perf record ./workload
> 
>   would end up using attr.precise_ip = 0. As a workaround this would
>   need to be done:
> 
> 	perf record -e cycles:P ./workload
> 
>   And on s/390 it would plain not work, requiring using:
> 
>         perf record -e cycles ./workload
> 
>   as a workaround.  (Arnaldo Carvalho de Melo)
> 
> - Fix perf build with ARCH=x86_64, when ARCH should be transformed
>   into ARCH=x86, just like with the main kernel Makefile and
>   tools/objtool's, i.e. use SRCARCH. (Jiada Wang)
> 
> - Avoid accessing uninitialized data structures when unwinding with
>   elfutils's libdw, making it more closely mimic libunwind's unwinder.
>   (Milian Wolff)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf evsel: Fix probing of precise_ip level for default cycles event
> 
> Jiada Wang (1):
>       perf tools: Fix build with ARCH=x86_64
> 
> Milian Wolff (1):
>       perf unwind: Report module before querying isactivation in dwfl unwind
> 
>  tools/perf/Makefile.config     | 38 +++++++++++++++++++-------------------
>  tools/perf/Makefile.perf       |  2 +-
>  tools/perf/arch/Build          |  2 +-
>  tools/perf/pmu-events/Build    |  4 ++--
>  tools/perf/tests/Build         |  2 +-
>  tools/perf/tests/task-exit.c   |  2 +-
>  tools/perf/util/evsel.c        | 12 ++++++++++++
>  tools/perf/util/header.c       |  2 +-
>  tools/perf/util/unwind-libdw.c |  8 ++++++++
>  9 files changed, 46 insertions(+), 26 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL 0/3] perf/urgent fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-16 21:30 +0200
  [PATCH 1/3] perf evsel: Fix probing of precise_ip level for default cycles event Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-16 21:30 +0200
  Re: [GIT PULL 0/3] perf/urgent fixes Ingo Molnar <mingo@kernel.org> - 2017-06-16 21:40 +0200

csiph-web