Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1667998

Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs
Date 2017-06-16 20:30 +0200
Message-ID <tT4an-3MU-35@gated-at.bofh.it> (permalink)
References <tSToB-4Ym-11@gated-at.bofh.it> <tSToC-4Ym-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 16 Jun 2017 16:57:14 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:

> After reconfiguring watchdog sysctls etc., architecture specific
> watchdogs may not get all their parameters updated.
> 
> watchdog_reconfigure() can be implemented to pull the new values
> in and set the arch NMI watchdog.
> 

I'll update the title and changelog to say "watchdog_nmi_reconfigure".

> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -123,6 +123,11 @@ void __weak watchdog_nmi_disable(unsigned int cpu)
>  {
>  }
>  
> +void __weak watchdog_nmi_reconfigure(void)
> +{
> +}

Can we please get some documentation in here describing what it's for? 
How arch maintainers might use this?  When and why it is called, what
it must do?  etc.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs Nicholas Piggin <npiggin@gmail.com> - 2017-06-16 09:00 +0200
  Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for  arch watchdogs Andrew Morton <akpm@linux-foundation.org> - 2017-06-16 20:30 +0200
    Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for  arch watchdogs Nicholas Piggin <npiggin@gmail.com> - 2017-06-17 05:00 +0200

csiph-web