Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.
Date	2017-06-16 16:50 +0200
Message-ID	<tT0Jr-1ld-7@gated-at.bofh.it> (permalink)
References	<tSJSh-7i5-3@gated-at.bofh.it> <tSJSh-7i5-11@gated-at.bofh.it> <tSSiR-4jS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Archit Taneja <architt@codeaurora.org> writes:

> On 06/16/2017 02:11 AM, Eric Anholt wrote:
>> If the panel-bridge is being set up after the drm_mode_config_reset(),
>> then the connector's state would never get initialized, and we'd
>> dereference the NULL in the hotplug path.  We also need to register
>> the connector, so that userspace can get at it.
>> 
>
> Shouldn't the KMS driver make sure the panel-bridge is set up before
> drm_mode_config_reset? Is it the case when we're inserting the
> panel-bridge driver as a module?
>
>
> All the connectors that have been added are registered automatically
> when drm_dev_register() is called by the KMS driver. Registering a
> connector in the middle of setting up our driver is prone to race
> conditions if the userspace decides to use them immediately.

Yeah, this is fixing initializing panel_bridge at DSI host_attach time,
which in the case of a panel module that creates the DSI device
(adv7533-style, like you said I should use as a reference) will be after
drm_mode_config_reset() and drm_dev_register().

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] drm/bridge: Support hotplugging panel-bridge. Eric Anholt <eric@anholt.net> - 2017-06-15 22:50 +0200
  Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge. Archit Taneja <architt@codeaurora.org> - 2017-06-16 07:50 +0200
    Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge. Eric Anholt <eric@anholt.net> - 2017-06-16 16:50 +0200

csiph-web