Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228

From	Heiko Stübner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228
Date	2017-06-15 10:00 +0200
Message-ID	<tSxR8-88I-13@gated-at.bofh.it> (permalink)
References	<tSxep-7TU-3@gated-at.bofh.it> <tSxeq-7TU-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Frank,

Am Donnerstag, 15. Juni 2017, 15:16:16 CEST schrieb Frank Wang:
> From: Shawn Lin <shawn.lin@rock-chips.com>
> 
> Add "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc" for
> dwmmc on rk322x platform.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt index
> 520d61d..ce30dff 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> @@ -15,6 +15,7 @@ Required Properties:
>  	- "rockchip,rk3288-dw-mshc": for Rockchip RK3288
>  	- "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RV1108 - "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RK3036 +	- "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK322X - "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3368 - "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3399

you might want to rebase this patch on top of Ulfs next branch [0],
as there is also the support for the rk3328 in there now.

Otherwise looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>



[0] https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/log/?h=next

Thread

[PATCH 0/6] add some device nodes support for rk322x SoC Frank Wang <frank.wang@rock-chips.com> - 2017-06-15 09:20 +0200
  [PATCH 3/6] ARM: dts: rockchip: fix compatible string for eMMC node of rk3228 SoC Frank Wang <frank.wang@rock-chips.com> - 2017-06-15 09:20 +0200
  [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228 Frank Wang <frank.wang@rock-chips.com> - 2017-06-15 09:20 +0200
    Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228 Heiko Stübner <heiko@sntech.de> - 2017-06-15 10:00 +0200
  [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 Frank Wang <frank.wang@rock-chips.com> - 2017-06-15 09:30 +0200
    Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 Heiko Stuebner <heiko@sntech.de> - 2017-06-15 17:20 +0200
      Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 Frank Wang <frank.wang@rock-chips.com> - 2017-06-16 11:30 +0200
        Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 Heiko Stübner <heiko@sntech.de> - 2017-06-16 11:40 +0200
  [PATCH 5/6] ARM: dts: rockchip: Add io-domain node for rk3228 Frank Wang <frank.wang@rock-chips.com> - 2017-06-15 09:30 +0200

csiph-web