Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver
Date	2017-06-15 07:20 +0200
Message-ID	<tSvmi-6IX-3@gated-at.bofh.it> (permalink)
References	<tSmsG-Tw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote:
> --- /dev/null
> +++ b/include/linux/fsi-sbefifo.h
> @@ -0,0 +1,30 @@
> +/*
> + * SBEFIFO FSI Client device driver
> + *
> + * Copyright (C) IBM Corporation 2017
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERGCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef LINUX_FSI_SBEFIFO_H
> +#define LINUX_FSI_SBEFIFO_H
> +
> +struct device;
> +struct sbefifo_client;
> +
> +extern struct sbefifo_client *sbefifo_drv_open(struct device *dev,
> +					       unsigned long flags);
> +extern int sbefifo_drv_read(struct sbefifo_client *client, char *buf,
> +			    size_t len);
> +extern int sbefifo_drv_write(struct sbefifo_client *client, const char *buf,
> +			     size_t len);
> +extern void sbefifo_drv_release(struct sbefifo_client *client);
> +
> +#endif /* LINUX_FSI_SBEFIFO_H */

Why do you need this .h file at all?  Nothing is calling it, right?

thanks,

greg k-h

Thread

[PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver "Edward A. James" <eajames@us.ibm.com> - 2017-06-14 21:50 +0200
  Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver Greg KH <gregkh@linuxfoundation.org> - 2017-06-15 07:20 +0200
  Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver Greg KH <gregkh@linuxfoundation.org> - 2017-06-15 07:20 +0200
  Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver Greg KH <gregkh@linuxfoundation.org> - 2017-06-15 07:30 +0200
  Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver Greg KH <gregkh@linuxfoundation.org> - 2017-06-15 07:30 +0200
  Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver Greg KH <gregkh@linuxfoundation.org> - 2017-06-15 07:30 +0200

csiph-web