Re: [PATCH v4 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set
Date	Thu, 15 Jun 2017 05:30:01 +0200
Message-ID	<tStDP-5y0-7@gated-at.bofh.it> (permalink)
References	<tQsLU-2vh-13@gated-at.bofh.it> <tQsLV-2vh-33@gated-at.bofh.it>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mail.kernel.org 3A6E122CB7
Authentication-Results	mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results	mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	82
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, devicetree@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>, kernel@pengutronix.de, Liam Girdwood <lgirdwood@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>, Stephen Boyd <sboyd@codeaurora.org>
X-Original-Date	Thu, 15 Jun 2017 11:24:26 +0800
X-Original-Message-ID	<20170615032425.GG30112@dragon>
X-Original-References	<20170609140739.15726-1-o.rempel@pengutronix.de> <20170609140739.15726-3-o.rempel@pengutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1666432

Show key headers only | View raw

+Leonard, in case he wants to have a look.

One small comment below ...

On Fri, Jun 09, 2017 at 04:07:35PM +0200, Oleksij Rempel wrote:
> One of the Freescale recommended sequences for power off with external
> PMIC is the following:
> ...
> 3.  SoC is programming PMIC for power off when standby is asserted.
> 4.  In CCM STOP mode, Standby is asserted, PMIC gates SoC supplies.
> 
> See:
> http://www.nxp.com/assets/documents/data/en/reference-manuals/IMX6DQRM.pdf
> page 5083
> 
> This patch implements step 4. of this sequence.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/mach-imx/pm-imx6.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> index e61b1d1027e1..3a4f8f289f4d 100644
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -27,6 +27,8 @@
>  #include <asm/proc-fns.h>
>  #include <asm/suspend.h>
>  #include <asm/tlb.h>
> +#include <linux/kallsyms.h>
> +#include <linux/regulator/machine.h>

How are these headers used?

Shawn

>  
>  #include "common.h"
>  #include "hardware.h"
> @@ -602,6 +604,28 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata
>  				   IMX6Q_GPR1_GINT);
>  }
>  
> +static void imx6_pm_poweroff(void)
> +{
> +	imx6_set_lpm(STOP_POWER_OFF);
> +	cpu_suspend(0, imx6q_suspend_finish);
> +
> +	mdelay(1000);
> +
> +	pr_emerg("Unable to poweroff system\n");
> +}
> +
> +static int imx6_pm_poweroff_probe(void)
> +{
> +	if (pm_power_off) {
> +		pr_warn("%s: pm_power_off already claimed  %p %pf!\n",
> +			__func__, pm_power_off, pm_power_off);
> +		return -EBUSY;
> +	}
> +
> +	pm_power_off = imx6_pm_poweroff;
> +	return 0;
> +}
> +
>  void __init imx6_pm_ccm_init(const char *ccm_compat)
>  {
>  	struct device_node *np;
> @@ -618,6 +642,9 @@ void __init imx6_pm_ccm_init(const char *ccm_compat)
>  	val = readl_relaxed(ccm_base + CLPCR);
>  	val &= ~BM_CLPCR_LPM;
>  	writel_relaxed(val, ccm_base + CLPCR);
> +
> +	if (of_property_read_bool(np, "fsl,pmic-stby-poweroff"))
> +		imx6_pm_poweroff_probe();
>  }
>  
>  void __init imx6q_pm_init(void)
> -- 
> 2.11.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set Oleksij Rempel <o.rempel@pengutronix.de> - 2017-06-09 16:10 +0200
  Re: [PATCH v4 2/6] ARM: imx6: register pm_power_off handler if  "fsl,pmic-stby-poweroff" is set Shawn Guo <shawnguo@kernel.org> - 2017-06-15 05:30 +0200

csiph-web