Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1666393

[PATCH] USB: gtco: remove unnecessary variable assignments

From "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups linux.kernel
Subject [PATCH] USB: gtco: remove unnecessary variable assignments
Date 2017-06-15 04:40 +0200
Message-ID <tSsRs-52d-21@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Remove unnecessary variable assignments.
Variable _val_ is overwritten before the value stored in it can be used.

Addresses-Coverity-ID: 1397695
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/input/tablet/gtco.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index b796e89..d9de13c 100644
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -652,8 +652,6 @@ static void gtco_urb_callback(struct urb *urbinfo)
 		switch (device->buffer[0]) {
 		case 5:
 			/* Pressure is 9 bits */
-			val = ((u16)(device->buffer[8]) << 1);
-			val |= (u16)(device->buffer[7] >> 7);
 			input_report_abs(inputdev, ABS_PRESSURE,
 					 device->buffer[8]);
 
-- 
2.5.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] USB: gtco: remove unnecessary variable assignments "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-15 04:40 +0200
  Re: [PATCH] USB: gtco: remove unnecessary variable assignments Joe Perches <joe@perches.com> - 2017-06-15 07:10 +0200
    Re: [PATCH] USB: gtco: remove unnecessary variable assignments ulrik.debie-os@e2big.org - 2017-06-15 22:10 +0200

csiph-web