Re: [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section

From	Wei Yang <richard.weiyang@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section
Date	2017-06-15 03:10 +0200
Message-ID	<tSrsl-4da-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <tQLlw-5qz-9@gated-at.bofh.it> <tS9ON-1zn-1@gated-at.bofh.it> <tSa89-1FC-3@gated-at.bofh.it> <tScD0-3kg-19@gated-at.bofh.it> <tScMH-3nJ-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jun 14, 2017 at 11:24:38AM +0200, Michal Hocko wrote:
>On Wed 14-06-17 17:12:06, Wei Yang wrote:
>> On Wed, Jun 14, 2017 at 08:32:06AM +0200, Michal Hocko wrote:
>> >On Wed 14-06-17 14:12:59, Wei Yang wrote:
>> >[...]
>> >> Hi, Michal
>> >> 
>> >> Not sure you missed this one or you think this is fine.
>> >> 
>> >> Hmm... this will not happen since we must offline a whole memory_block?
>> >
>> >yes
>> >
>> >> So the memory_hotplug/unplug unit is memory_block instead of mem_section?
>> >
>> >yes.
>> 
>> If this is true, the check_hotplug_memory_range() should be fixed too.
>
>as I've said earlier. There are many code paths which are quite
>confusing and they expect sub-section granularity while they in fact
>won't work with sub memblock granularity. This is a larger project
>I am afraid and it would be great if you are willing to try to
>consolidate that code. I have that on my todo list but there are more
>pressing things to address first for me now.
>

Yep, I am willing to have a try. :-)

>-- 
>Michal Hocko
>SUSE Labs

-- 
Wei Yang
Help you, Help me

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-10 12:00 +0200
  Re: [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-10 17:00 +0200
    Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-06-12 09:00 +0200
      Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-14 08:20 +0200
  Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-14 08:20 +0200
    Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-06-14 08:40 +0200
      Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-14 11:20 +0200
        Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Michal Hocko <mhocko@kernel.org> - 2017-06-14 11:30 +0200
          Re: [PATCH 04/14] mm, memory_hotplug: get rid of  is_zone_device_section Wei Yang <richard.weiyang@gmail.com> - 2017-06-15 03:10 +0200

csiph-web