[PATCH v1 1/1] gpio: gpio-crystalcove: Skip IRQ CTRL register update for virtual GPIOs

From	sathyanarayanan.kuppuswamy@linux.intel.com
Newsgroups	linux.kernel
Subject	[PATCH v1 1/1] gpio: gpio-crystalcove: Skip IRQ CTRL register update for virtual GPIOs
Date	2017-06-15 01:30 +0200
Message-ID	<tSpTA-3aq-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Commit 9a752b4c9ab9 ("gpio: crystalcove: Do not write regular gpio
registers for virtual GPIOs") added support to skip GPIO register
update for virtual GPIOs, but it missed to add skip logic in
crystalcove_update_irq_ctrl() function. This patch fixes it.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 drivers/gpio/gpio-crystalcove.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index e60156e..edc9aa8 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -134,6 +134,9 @@ static void crystalcove_update_irq_ctrl(struct crystalcove_gpio *cg, int gpio)
 {
 	int reg = to_reg(gpio, CTRL_IN);
 
+	if (reg < 0)
+		return;
+
 	regmap_update_bits(cg->regmap, reg, CTLI_INTCNT_BE, cg->intcnt_value);
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] gpio: gpio-crystalcove: Skip IRQ CTRL register update for virtual GPIOs sathyanarayanan.kuppuswamy@linux.intel.com - 2017-06-15 01:30 +0200
  Re: [PATCH v1 1/1] gpio: gpio-crystalcove: Skip IRQ CTRL register  update for virtual GPIOs Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-15 11:30 +0200
    Re: [PATCH v1 1/1] gpio: gpio-crystalcove: Skip IRQ CTRL register  update for virtual GPIOs sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-06-15 23:50 +0200

csiph-web