Re: [PATCH 12/12] tracing: Rename update the enum_map file

From	Jeremy Linton <jeremy.linton@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/12] tracing: Rename update the enum_map file
Date	2017-06-14 20:50 +0200
Message-ID	<tSlwB-jl-3@gated-at.bofh.it> (permalink)
References	<tNjON-28K-3@gated-at.bofh.it> <tNjON-28K-15@gated-at.bofh.it> <tS1od-4EQ-13@gated-at.bofh.it> <tS1xT-4HZ-1@gated-at.bofh.it> <tSjXP-7Wy-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/14/2017 12:06 PM, Steven Rostedt wrote:
> On Tue, 13 Jun 2017 16:21:48 -0500
> Jeremy Linton <jeremy.linton@arm.com> wrote:
> 
>>> Hmm, I have to audit some userspace code to see if this is used. The
>>> enum_map was a debug feature, but it could have been used by some tools.
>>
>> I thought perf was using it, but I was mistaken. I didn't find anything
>> using it, but to be on the safe side I placed this patch last so it
>> could be dropped if a user was found. The CONFIG option seems to be
>> disabled in the couple distro's I checked, further indicating that if
>> someone is using it, they are seemingly obscure.
> 
> I pulled in all your patches but the samples one. Could you update that
> with a use case as well. You can create some crazy struct that you want
> to get the size of, or whatever. Maybe make an array out of it? Or I
> can come up with something creative.

I was actually working on that, it seems that the existing sample has 
the problem because of the __print_array(...sizeof(int)) case. So I 
think my general plan was just to update it to TRACE_DEFINE_SIZEOF(int).

Do you want a more complex example?

But this lead me to discover a number of other __print_array() cases 
where people have hardcoded the size, so I was running through those and 
converting them to sizeof() since it should work now.

> 
> I'll start testing your patches and do a push in a few days.
> 
> -- Steve
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 12/12] tracing: Rename update the enum_map file Steven Rostedt <rostedt@goodmis.org> - 2017-06-13 23:20 +0200
  Re: [PATCH 12/12] tracing: Rename update the enum_map file Jeremy Linton <jeremy.linton@arm.com> - 2017-06-13 23:30 +0200
    Re: [PATCH 12/12] tracing: Rename update the enum_map file Steven Rostedt <rostedt@goodmis.org> - 2017-06-14 19:10 +0200
      Re: [PATCH 12/12] tracing: Rename update the enum_map file Jeremy Linton <jeremy.linton@arm.com> - 2017-06-14 20:50 +0200

csiph-web