Re: [RFC PATCH 02/10] objtool, x86: add several functions and files to the objtool whitelist

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 02/10] objtool, x86: add several functions and files to the objtool whitelist
Date	2017-06-14 15:10 +0200
Message-ID	<tSgdz-5BT-15@gated-at.bofh.it> (permalink)
References	<tNr9D-6Ua-3@gated-at.bofh.it> <tNr9E-6Ua-27@gated-at.bofh.it> <tSaUy-2dU-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 09:24:39AM +0200, Jiri Slaby wrote:
> On 06/01/2017, 07:44 AM, Josh Poimboeuf wrote:
> ...
> > --- a/arch/x86/kernel/kprobes/opt.c
> > +++ b/arch/x86/kernel/kprobes/opt.c
> > @@ -28,6 +28,7 @@
> >  #include <linux/kdebug.h>
> >  #include <linux/kallsyms.h>
> >  #include <linux/ftrace.h>
> > +#include <linux/frame.h>
> >  
> >  #include <asm/text-patching.h>
> >  #include <asm/cacheflush.h>
> > @@ -94,6 +95,7 @@ static void synthesize_set_arg1(kprobe_opcode_t *addr, unsigned long val)
> >  }
> >  
> >  asm (
> > +			"optprobe_template_func:\n"
> 
> Why do you add another symbol here? What's wrong with
> optprobe_template_entry?

I tried to do that, but the STACK_FRAME_NON_STANDARD macro needs a
function, and optprobe_template_entry is defined elsewhere as a data
symbol with a type of kprobe_opcode_t.  So I had to wrap the asm code
inside a function.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 02/10] objtool, x86: add several functions and files  to the objtool whitelist Jiri Slaby <jslaby@suse.cz> - 2017-06-14 09:30 +0200
  Re: [RFC PATCH 02/10] objtool, x86: add several functions and files  to the objtool whitelist Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-14 15:10 +0200

csiph-web