Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665838
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration |
| Date | 2017-06-14 15:40 +0200 |
| Message-ID | <tSgGC-5Le-13@gated-at.bofh.it> (permalink) |
| References | <tSe26-459-43@gated-at.bofh.it> <tSgGB-5Le-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2017-06-14 at 15:35 +0200, Steffen Maier wrote:
> Fixes the following false warning
> among others for LLIST_HEAD and PLIST_HEAD:
>
> WARNING: Missing a blank line after declarations
> #71: FILE: drivers/s390/scsi/zfcp_fsf.c:422:
> + struct hlist_node *tmp;
> + HLIST_HEAD(remove_queue);
>
> Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
> ---
> Changes from v1:
> Extended it to also support LLIST_HEAD and PLIST_HEAD as suggested by
> Joe Perches.
Acked-by: Joe Perches <joe@perches.com>
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4b9569fa931b..86818b0ba8be 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -732,7 +732,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
>
> our $declaration_macros = qr{(?x:
> (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
> - (?:$Storage\s+)?LIST_HEAD\s*\(|
> + (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
> (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
> )};
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] checkpatch: HLIST_HEAD is also declaration Steffen Maier <maier@linux.vnet.ibm.com> - 2017-06-14 12:20 +0200
Re: [PATCH] checkpatch: HLIST_HEAD is also declaration Joe Perches <joe@perches.com> - 2017-06-14 12:50 +0200
Re: [PATCH] checkpatch: HLIST_HEAD is also declaration Joe Perches <joe@perches.com> - 2017-06-14 12:50 +0200
[PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration Steffen Maier <maier@linux.vnet.ibm.com> - 2017-06-14 15:40 +0200
Re: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration Joe Perches <joe@perches.com> - 2017-06-14 15:40 +0200
Re: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration Steffen Maier <maier@linux.vnet.ibm.com> - 2017-06-14 15:50 +0200
Re: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration Joe Perches <joe@perches.com> - 2017-06-14 15:50 +0200
csiph-web